-
Couldn't load subscription status.
- Fork 793
[SYCL] Add operators to sycl::vec<std::byte> specialization #20440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The SYCL spec allows the following operators for sycl::vec<std::byte>:
Comparison: ==, !=, <, <=, >, >=
Bitwise: &, |, ^, ~, &=, |=, ^=
This spec revision was introduced in the SYCL-Docs PR intel#674.
|
I thought I've implemented all the The changes to align "preview" And we enabled that (and other PRs') new implementation under On top of that, I believe we will be entering ABI breaking window for the next major release in a few weeks, when we'll "un-guard" those breaking changes and make them active by default without extra options. |
|
Thanks for the pointers to the PRs! I might be missing something, but I don't see how these PRs enable the DPC++ release v6.2 used a version of SYCL-CTS (87f8677c), which did does test these |
|
Using $ cat a.cpp
#include <sycl/sycl.hpp>
int main() {
auto testVec1 = sycl::vec<std::byte, 1>(static_cast<std::byte>(1));
auto testVec2 = sycl::vec<std::byte, 1>(static_cast<std::byte>(2));
auto resVec = testVec1 == testVec2;
} I've also checked that 6.2 release reports the same error in both default/preview modes indeed. I think 6.3 will include the fixes necessary though. |
|
Okay, I haven't tried with commits beyond v6.2. Thanks for checking! Closing. |
The SYCL spec allows the following operators for
sycl::vec<std::byte>Comparison: ==, !=, <, <=, >, >=
Bitwise: &, |, ^, ~, &=, |=, ^=
This sycl::vec spec change was introduced in SYCL-Docs PR #674.